commaai / flash

https://flash.comma.ai
5 stars 20 forks source link

Replace React with something simple #42

Open adeebshihadeh opened 5 months ago

adeebshihadeh commented 5 months ago

Replace next/react/etc with a simpler stack. This will be a try-out for comma connect's next framework.

We care about simplicity, brevity, and performance. Some contenders:

Nice site with benchmarks of a bunch of frameworks: https://krausest.github.io/js-framework-benchmark/current.html


EDIT: Some more context on what we're looking for:

I just wrote comma.ai/leaderboard. It loads instantly; you click refresh and don't even see it load. It has a defined JS-less experience and only uses JS where absolutely necessary. I simply started with vi leaderboard.html and got to work.

It was a joy to write, but there were a few pain points:

wgenh commented 5 months ago

Can you check https://github.com/commaai/flash/pull/43 ?

adeebshihadeh commented 5 months ago

Can you check #43 ?

I updated the description with some more info. Is #43 a step towards that?

wgenh commented 5 months ago

Can you check #43 ?

I updated the description with some more info. Is #43 a step towards that?

I think so, the page loads without any js

yaodingyd commented 5 months ago

I'd like to mention that Astro might be the better fit https://astro.build since it's targeted for content heavy website with slight interactivity , default zero js, and support incrementally adding any js framework component. I don't want to step on anyone's toes though, not sure if this is already locked to anything

trentrand commented 4 months ago

@adeebshihadeh, I submitted #50 to demonstrate the same performance as comma.ai/leaderboard while remaining as React

Miraj98 commented 4 months ago

@adeebshihadeh I have mostly migrated this to plain Typescript + HTML but I had a doubt. Is this still using android-fastboot? Saw some previous issues regarding moving away from fastboot to QDL

PGuimarais commented 2 months ago

Preact can get the bundle size down substantially whilst maintaining DX

knownotunknown commented 1 month ago

Hey @adeebshihadeh, not sure if @trentrand's PR https://github.com/commaai/flash/pull/50 might've slipped by you, so just wanted to follow up for him (and me to see if the bounty should still be open).

c-gamble commented 1 month ago

I would like to work on (ideally lock) this bounty. I'm creating a completely from-scratch implementation to give the most performative UX.

adeebshihadeh commented 1 month ago

So this bounty is a combo of exploratory and a hiring challenge, so there's no locks for it. It'll just be closed once we merge something good!

Technologeek commented 1 month ago

My Take (very early but would like to see if we can take this approach)? #66