search

commaai / flash

https://flash.comma.ai
5 stars 14 forks source link

[$500 Bounty] Switch from fastboot to EDL/QDL #7

Closed adeebshihadeh closed 4 months ago

adeebshihadeh commented 1 year ago

QDL should be a strict improvement

Seems like there's two options here:

  1. flash the whole thing with firehose
  2. load an EDL loader with fastboot and use the existing stuff to flash

Here's a good Python implementation: https://github.com/bkerler/edl.

adeebshihadeh commented 1 year ago

Bounty details:

Write a nice QDL.js library and integrate it into commaai/flash. The library only needs the functionality necessary for the flasher. No comma hardware necessary; show it works reliably on an Android phone and we'll do any final testing needed on our hardware.

Bounty locked once a PR is open that connects to a device in QDL and paid out once it's merged.

aseok commented 1 year ago

@adeebshihadeh I already have started working on this. will be payment in cryptocurrencies possible?

adeebshihadeh commented 1 year ago

I’d have to check, but I think so.

aseok commented 1 year ago

I have ported most of python code to js but wondered if it's better to port it to typescript first, then compile to js...

On Wed, Aug 30, 2023, 5:18 PM Adeeb Shihadeh @.***> wrote:

I’d have to check, but I think so.

— Reply to this email directly, view it on GitHub https://github.com/commaai/flash/issues/7#issuecomment-1699227209, or unsubscribe https://github.com/notifications/unsubscribe-auth/AD5KKLBUHGHZPDXUIDOG5MLXX5AELANCNFSM6AAAAAA3L3SBMY . You are receiving this because you commented.Message ID: @.***>

adeebshihadeh commented 12 months ago

Doesn't matter to me, but perhaps @incognitojam has some thoughts on this.

incognitojam commented 12 months ago

either TypeScript or JSDoc to add type hints is good!

aseok commented 9 months ago

@adeebshihadeh code migration in progress. It would be nice to increase bounty to 1k$.

adeebshihadeh commented 9 months ago

What code migration? I would pay more for a PR that I can just click merge on right now, but I haven't seen anything yet.

adeebshihadeh commented 7 months ago

@bongbui321 you've done a great job with a bunch of bounties. any interest in this one?

bongbui321 commented 7 months ago

@adeebshihadeh definitely, I did see your post on discord the other day, but I have neither the comma nor an android device to start working on this bounty. So I thought it would be faster for others who have more experience in this subject to work on this since you want this to be done quick

andiradulescu commented 7 months ago

@adeebshihadeh I can also try this, but not immediately.

@bongbui321 no comma hardware needed https://github.com/commaai/flash/issues/7#issuecomment-1693963821, you just need an android device with QDL/qualcomm - maybe you can borrow an old one from someone else.

I will write a new comment before I start trying to lock it.

andiradulescu commented 7 months ago

@bongbui321 you try and lock this. I will not try in parallel. if you realize that you can't do it, I will try after.

andiradulescu commented 7 months ago

@adeebshihadeh noticed your changes https://github.com/commaai/agnos-builder/pull/198 - will you also update https://github.com/commaai/agnos ? this might help, since the same "methods" from "edl" and flash files will be used in/with the new "QDL.js".

adeebshihadeh commented 7 months ago

@adeebshihadeh noticed your changes commaai/agnos-builder#198 - will you also update https://github.com/commaai/agnos ? this might help, since the same "methods" from "edl" and flash files will be used in/with the new "QDL.js".

I put up a bounty for it https://github.com/commaai/agnos-builder/issues/200

adeebshihadeh commented 4 months ago

Done, thanks to @bongbui321!