search

commaai / laika

Simple Python GNSS processing library
MIT License
647 stars 179 forks source link

fixing bug with downloader and walkthrough notebook #67

Closed sahandzou closed 2 years ago

sahandzou commented 2 years ago

Hi Harald,

I was going through the walkthrough notebook. I faced some bugs in the downloader; it uses Hatanaka decompression for decompressing satellite orbits files; it was incorrect as they aren't RINEX files so I changed the downloader as it was before using Hatanaka for decompressing data, and also there was some issue with the walkthrough notebook that I fixed them too.

valgur commented 2 years ago

I guess you could consider it a regression in hatanaka. I added a check to the decompression function to verify that the decoded file is RINEX. It's actually ok to use the general decompression functions for other types of data too, though, so I'll revert that and make it optional.

valgur commented 2 years ago

Fixed now in v2.6.0.

sahandzou commented 2 years ago

Fixed now in v2.6.0.

Great! Thank You.