search

commaai / laika

Simple Python GNSS processing library
MIT License
647 stars 179 forks source link

Cleanup and typing #70

Closed gijskoning closed 2 years ago

adeebshihadeh commented 2 years ago

If you're going to add typing, can you bring over the pre-commit config from openpilot? I think that one's a bit stricter and on a different mypy version. Otherwise, we can run into issues where the laika tests pass, but laika files fail openpilot's CI.

gijskoning commented 2 years ago

Work in progress. Will remove changes from read_raw_ublox since that function should be in the openpilot repo anyway.

Will do the pre-commit as well, on Thursday!