search

commaai / laika

Simple Python GNSS processing library
MIT License
647 stars 179 forks source link

Refactor gnssmeasurements constructor #75

Closed gijskoning closed 2 years ago

gijskoning commented 2 years ago

Change UbloxGnssId to ConstellationId. Refactor gnssmeasurements constructor by replacing 'prn' with 'constellation_id' and 'svId' since prn is created from those two.

Found out that incoming qcom messages contain nmea_id 255 which is incorrect. Added a todo and the measurement will be skipped.

Verified with unit test and running from xx.

gijskoning commented 2 years ago

WIP will write some more tests tomorrow to ensure nothing breaks.

Edit: unit tests written in other pr