Post screenshots of preview sites in PR comments

commaai / new-connect

a rewrite of comma connect

https://new-connect.connect-d5y.pages.dev/

MIT License

12 stars 29 forks source link

Post screenshots of preview sites in PR comments #38

Closed signed-long closed 5 months ago

github-actions[bot] commented 5 months ago

Welcome to new-connect! Make sure to:

read the contributing guidelines
mark your PR as a draft until it's ready to review
post the preview on Discord; feedback from users will speedup the PR review

deployed preview: https://38.connect-d5y.pages.dev

adeebshihadeh commented 5 months ago

I made a new repo to push artifacts to: https://github.com/commaai/ci-artifacts. There's a deploy key for that repo in the CI_ARTIFACTS_DEPLOY_KEY GitHub secret.

I think the workflow file has to already use the secret in master, so if you make a minimal PR that does nothing but "echo", I'll merge that first so you can work on this.

signed-long commented 5 months ago

I made a new repo to push artifacts to: https://github.com/commaai/ci-artifacts. There's a deploy key for that repo in the CI_ARTIFACTS_DEPLOY_KEY GitHub secret.

I think the workflow file has to already use the secret in master, so if you make a minimal PR that does nothing but "echo", I'll merge that first so you can work on this.

Using the secret in master: https://github.com/commaai/new-connect/pull/40

incognitojam commented 5 months ago

I think you should be able to use the secret now (run: https://github.com/commaai/new-connect/actions/runs/9662194623/job/26651559106)

signed-long commented 5 months ago

From my fork - this is the comment produced: https://github.com/signed-long/new-connect/pull/4#issuecomment-2193369487

@adeebshihadeh, before merging will also need the https://github.com/commaai/ci-artifacts repo initialized. This PR pushes the images to new-comma/pr-<pr number> on main. But can adjust to however you want to structure that repo.