commaai / new-connect

a rewrite of comma connect
https://new-connect.connect-d5y.pages.dev/
MIT License
9 stars 28 forks source link

Implement PWA features #59

Open adeebshihadeh opened 4 months ago

adeebshihadeh commented 4 months ago

This issue is for making this a complete PWA, including but not limited to:

As well as testing the PWA-ness in CI.

adeebshihadeh commented 4 months ago

This looks interesting https://github.com/elegantapp/pwa-asset-generator

seanaguinaga commented 4 months ago

How's this: https://github.com/commaai/new-connect/pull/68

Oops need to add CI - standby

griffinbaker12 commented 4 months ago

Just a thought on the design for the exit screen I was working on:

Image

The asset generator linked above also integrates really well with the rest of the project. I ran:

npx pwa-asset-generator ./public/images/icon-vector.svg ./temp -b "#141414" -m public/manifest.json -i ./index.html

to make sure the app's bg on the phone screen matched that of the svg icon.

If helpful, you can find the approach I was taking here.

theVedanta commented 2 months ago

Hello, Is this issue closed? I would like to try this out

namnbk commented 1 month ago

Is this still available?

griffinbaker12 commented 1 month ago

anything not closed is open, but they aren't focusing on this rn @theVedanta @namnbk