commaai / new-connect

a rewrite of comma connect

https://new-connect.connect-d5y.pages.dev/

MIT License

12 stars 29 forks source link

PWA Support #68

Open seanaguinaga opened 4 months ago

seanaguinaga commented 4 months ago

https://new-connect-beta.vercel.app/

Add to home screen

turn on airplane mode to see offline fallback - not sure what you exactly want with this?

Assets are all generated from the two logo svgs - run build to see them in the dist folder

github-actions[bot] commented 4 months ago

68.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

read the contributing guidelines
mark your PR as a draft until it's ready to review
post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

adeebshihadeh commented 4 months ago

This PR is +100 lines net, including a bunch of new dependencies and configs. I suspect doing all the PWA stuff ourselves would be less than or equal to this.

seanaguinaga commented 4 months ago

This PR is +100 lines net, including a bunch of new dependencies and configs. I suspect doing all the PWA stuff ourselves would be less than or equal to this.

Adding the splash screen meta tags is 60 lines alone in the html Listing all the device sizes, names etc. etc.

Maintaining a list of sizes of assets for new devices, configuring service workers, etc. is a lot of grunt work that is not something I think any team should really be focused on maintaining or generating.

Much more than 100 lines unfortunately