commaai / new-connect

a rewrite of comma connect

https://new-connect.connect-d5y.pages.dev/

MIT License

9 stars 26 forks source link

Sort routes based on `create_time` #69

Open vishalkrishnads opened 2 months ago

vishalkrishnads commented 2 months ago

Fixes #60. Got rid of the pages[] array and implemented a more straightforward list rendering logic. The onLoadMore() method for infinite scrolling has been preserved. The dates/times on all the route cards have been removed.

github-actions[bot] commented 2 months ago

69.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

read the contributing guidelines
mark your PR as a draft until it's ready to review
post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

mfeinLearn commented 1 month ago

Are the conflicts resolved yet?

vishalkrishnads commented 1 month ago

The conflicts have been resolved. However, I'm seeing that /src/pages/dashboard/activities/PairActivity.tsx has a lot of unsafe call, returns & assignments. I've disabled everything for now since that is out of the scope of this PR. Worth checking later.

mfeinLearn commented 1 month ago

Congrats on the passing tests!!

vishalkrishnads commented 1 month ago

😂 seriously?