commaai / new-connect

a rewrite of comma connect

https://new-connect.connect-d5y.pages.dev/

MIT License

11 stars 29 forks source link

Added comments re: package.json #71

Closed griffinbaker12 closed 4 months ago

griffinbaker12 commented 4 months ago

Per my conversation with @adeebshihadeh in Discord, I added comments regarding what each package in the package.json does. I added the comments to a separate MD file b/c the pre-commit hook complained.

github-actions[bot] commented 4 months ago

71.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

read the contributing guidelines
mark your PR as a draft until it's ready to review
post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

adeebshihadeh commented 4 months ago

Let's do this? I worry a separate file won't get updated.

https://github.com/c-hive/guides/blob/8dd6863feb69208c2d49fc8d5356cf8e775bde1d/js/best-practices.md#comment-dependencies-in-the-packagejson

griffinbaker12 commented 4 months ago

that's a great reference

adeebshihadeh commented 4 months ago

Looks like there's a bad merge?

griffinbaker12 commented 4 months ago

yeah hmm happened on my other PR too #85 going to try re-opening other from fresh branch