commaai / new-connect

a rewrite of comma connect
https://new-connect.connect-d5y.pages.dev/
MIT License
11 stars 29 forks source link

Use hls light #74

Closed signed-long closed 4 months ago

signed-long commented 4 months ago

hls.js has a light build that removes some mostly audio related functionality.

From https://github.com/video-dev/hls.js#build-tasks:

NOTE: hls.light.*.js dist files do not include alternate-audio, subtitles, CMCD, EME (DRM), or Variable Substitution support. In addition, the following types are not available in the light build:

  • AudioStreamController
  • AudioTrackController
  • CuesInterface
  • EMEController
  • SubtitleStreamController
  • SubtitleTrackController
  • TimelineController
  • CmcdController

Size difference:

RouteVideoPlayer-BW7fAlsk.js                     387.47KB
   hls.js/dist/hls.mjs                           
RouteVideoPlayer-CWnPZdkL.js                     289.48KB
   hls.js/dist/hls.light.min.js
adeebshihadeh commented 4 months ago

-100k, nice!

Is this already the minimal HLS we need or are there still some features we're not using?

adeebshihadeh commented 4 months ago

Another thought - any way we can just use the HTML5 <video> element? What would it take to switch to that?

signed-long commented 4 months ago

-100k, nice!

Is this already the minimal HLS we need or are there still some features we're not using?

Yeah this is using the minimal version

Another thought - any way we can just use the HTML5 <video> element? What would it take to switch to that?

It's a browser support thing, some browsers can take the .m3u8 files and support hls streaming in the <video> tag natively. The hls library lets unsupported browsers (most) able to stream them too.

adeebshihadeh commented 4 months ago

I meant, can we strip down their light build even more for our use case?

github-actions[bot] commented 4 months ago

deployed preview: https://74.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

Mobile

Desktop