commaai / new-connect

a rewrite of comma connect

https://new-connect.connect-d5y.pages.dev/

MIT License

11 stars 29 forks source link

Fixes engage % #76

Open griffinbaker12 opened 4 months ago

griffinbaker12 commented 4 months ago

Fixes #75.

Ensures that the engaged and overriding states are mutually exclusive. The old logic would attribute both these states to engaged, leading to inflated stats.

adeebshihadeh commented 4 months ago

This should probably just come from the API, so all the logic is in one place. I'll have to look into that and come back to this.

github-actions[bot] commented 4 months ago

76.connect-d5y.pages.dev

Welcome to new-connect! Make sure to:

read the contributing guidelines
mark your PR as a draft until it's ready to review
post the preview on Discord; feedback from users will speedup the PR review

Mobile

Desktop

BBBmau commented 4 months ago

Looks to be better but like @adeebshihadeh said it would be best to get this directly from the API rather than calculating it on the client side.

griffinbaker12 commented 4 months ago

Looks to be better but like @adeebshihadeh said it would be best to get this directly from the API rather than calculating it on the client side.

yeah agreed, was cool to solve nonetheless