commaai / opendbc

a Python API for your car
MIT License
1.92k stars 1.11k forks source link

assert expected openpilot undefined message behavior #1050

Closed sshane closed 4 months ago

sshane commented 4 months ago

https://github.com/commaai/opendbc/pull/942 would now throw an uncaught out_of_range C++ exception for the packer when given unexpected message names

We probably do want to throw an exception (or at least log it), but we need really good discovery tests to catch anything before it becomes an exception in a user's car