search

commaai / opendbc

a Python API for your car
MIT License
1.92k stars 1.11k forks source link

packer: log undefined address/signal as error #1052

Closed sshane closed 3 months ago

sshane commented 3 months ago

split from https://github.com/commaai/opendbc/pull/942

from

cp.make_can_msg('test', 0, {'hi': 2})
undefined signal hi - 0
Out[3]: [0, 0, b'', 0]
cp.make_can_msg(999, 0, {'hi': 2})
undefined signal hi - 999
Out[4]: [999, 0, b'', 0]

to

cp.make_can_msg('test', 0, {'hi': 2})
opendbc/can/packer.cc: undefined address - 0
Out[3]: [0, 0, b'', 0]
cp.make_can_msg(999, 0, {'hi': 2})
opendbc/can/packer.cc: undefined address - 999
Out[4]: [999, 0, b'', 0]