search

commaai / opendbc

a Python API for your car
MIT License
1.91k stars 1.11k forks source link

Comma 3 boots into Dashcam Mode #1093

Open Verylukyguy opened 10 months ago

Verylukyguy commented 10 months ago

Describe the bug

The Comma 3 boots up intermittently in Dashcam Mode, seemingly after restarting the vehicle and resolves if the vehicle is restarted again. It is fingerprinting properly using FPv1; there are no missing Platforms on my Useradmin page.

Provide a route where the issue occurs

df51b2195de66a9b|2023-11-03--18-17-10--0

openpilot version

Comma Nightly @ 105ffa0

Additional info

No response

sshane commented 10 months ago

When you added your fingerprint in https://github.com/commaai/openpilot/pull/21545, it used a script which did not check the origin bus, as usually 0/2 is the same bus (PT and camera), but on ASCM GM, 2 is the chassis. There happens to be the same addresses with different lengths on 0 and 2 (like ECMEngineStatus), so some addresses in your fingerprint have an incorrect length on bus 0.

Verylukyguy commented 10 months ago

There were also earlier attempts to add my vehicle's fingerprint: https://github.com/commaai/openpilot/pull/2440 and https://github.com/commaai/openpilot/pull/21030 Maybe these are more complete/accurate.

The Acadia port originated here: https://github.com/commaai/openpilot/pull/338 and https://github.com/commaai/openpilot/pull/453

Verylukyguy commented 5 months ago

It does not appear to be a Fingerprinting issue because the Platform is correct on my Useradmin page when this happens. This issue developed only after a change in OpenPilot when a commit was merged, it had been working fine for three years.

sshane commented 5 months ago

Likely caused by https://github.com/commaai/openpilot/pull/27245. Can you share a recent bad route with uploaded rlogs?

Verylukyguy commented 5 months ago

This one is from yesterday: df51b2195de66a9b/0000005a--78b136e680/0

sshane commented 5 months ago

I should have a fix next week for you to test.

Verylukyguy commented 5 months ago

I am ready when you are @sshane.

Verylukyguy commented 5 months ago

Here is another route: df51b2195de66a9b/00000001--bc22ed8054/0

Verylukyguy commented 3 months ago

Here is another route: df51b2195de66a9b/00000007--12eddfcd96/0