commaai / opendbc

a Python API for your car
MIT License
1.95k stars 1.14k forks source link

CR-V Hybrid: possibly incorrect brake error signals #1104

Open sshane opened 2 years ago

sshane commented 2 years ago

A few of the cars use different brake error signals for the cruise fault alert, this user has a persistent cruise fault due to this. It's possible the DBC definition is incorrect and should be another set of signals (checked the other one, also doesn't look correct. one bit is 0 and the other oscillates with the vehicle speed. two WHEELS_MOVING bits on his car?). User reports brakes work as normal

420cb5afd2f5f563|2022-06-16--20-43-40--0

This only affects Bosch longitudinal

vanillagorillaa commented 1 year ago

When adding support for the clarity I also found that the brake error signals weren't correct and determined the following seemed to align with LKAS faults. Looks like in this route there is an 8 byte 0x184 message that may fit with the same definition in the clarity DBC. Would need more data to confirm

https://github.com/commaai/opendbc/blob/0a7560a2db05b5be359649def88ddda7fc8a0b49/honda_clarity_hybrid_2018_can_generated.dbc#L305