search

commaai / opendbc

a Python API for your car
MIT License
1.89k stars 1.1k forks source link

Hyundai Tucson 2023 poor tuning #1115

Open adeebshihadeh opened 1 year ago

adeebshihadeh commented 1 year ago

Waiting on more stock routes from user. 

8426de28ebdc65a2|2023-01-27--20-07-53
adeebshihadeh commented 1 year ago

Looks like it's just one FW version that needs different tuning. Temporarily removed it in commaai/openpilot#27340 until we better understand the difference.

sshane commented 1 year ago

@adeebshihadeh looks like this camera FW version was added again under SANTA_CRUZ_1ST_GEN. I wonder if it also has bad tuning. https://github.com/commaai/openpilot/pull/27395

sshane commented 1 year ago

@nuwandavek by the way, it looks like we have 4 active Tucson users in the last 90 days with these different camera part numbers: {'1966303b764e7142', '8426de28ebdc65a2', 'bf1a6b0ba293c37b', 'a0191364609ee493'}

sunnyhaibin commented 9 months ago

I've been running LAT_ACCEL = 2.9 - 3.1 and FRICTION = 0.095 for the past few days with the 2022 Hyundai Tucson Hybrid, and steering is now significantly better than the current values.

sshane commented 6 months ago

I would like to combine the Santa Cruz and Tucson. According to the wikipedia page, it is "closely related" to the Tucson as it shares the platform code with an extension of OB meaning Open Bed. The mass and wheel base are a bit different though. Regardless, the full camera FW and part number is shared across them, so we should be able to handle the differences (by detecting or learning).

@nuwandavek can you look at these two vehicles in the fleet and determine if using a median value is safe, letting torqued learn the difference?