commaai / opendbc

a Python API for your car
MIT License
1.89k stars 1.1k forks source link

2022 Chrysler Pacifica Hybrid bad steering PID tuning #1122

Open ns3284 opened 2 years ago

ns3284 commented 2 years ago

Describe the bug

Every so often, car gets into a ping ponging state where it bounces back and forth between lane edges. Sometimes it recovers, other times it runs away and requires manual stabilization.

Severe case can be found starting at 4395faadf0a373f2|2022-07-24--22-38-04--42 And ending at 4395faadf0a373f2|2022-07-24--22-38-04--43

Provide a route where the issue occurs

4395faadf0a373f2|2022-07-24--22-38-04--43

openpilot version

0.8.16 Nightly (e259656997)

Additional info

2022 Chrysler Pacifica Hybrid

adeebshihadeh commented 2 years ago

Can you try this branch https://github.com/commaai/openpilot/pull/25118 that uses the new torque controller?

ns3284 commented 2 years ago

I'll switch branches tomorrow and give it a shot, but no plans on highway driving to get a real test.

adeebshihadeh commented 2 years ago

Have you had a chance to try the branch?

ns3284 commented 2 years ago

Have not, sorry. I did see that nice new feature added to make changing branches easier though. Won't have any long drives until this weekend.

On Mon, Aug 1, 2022 at 1:14 PM Adeeb Shihadeh @.***> wrote:

Have you had a chance to try the branch?

— Reply to this email directly, view it on GitHub https://github.com/commaai/opendbc/issues/1122, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKIF3LFE3KHR4OLYWDOWZ7TVXAAX3ANCNFSM54Q2BJ6Q . You are receiving this because you authored the thread.Message ID: @.***>

-- Nicholas Sparks (ns3284) Columbia University, M.S. in Computer Science https://www.linkedin.com/in/nicholas-sparks/ https://www.linkedin.com/in/nicholas-sparks/ (609) 338-3074 @.***

adeebshihadeh commented 2 years ago

Have you had a chance to try the branch?

ns3284 commented 2 years ago

I'll switch branches tomorrow and use it this weekend.

On Sat, Aug 13, 2022, 00:42 Adeeb Shihadeh @.***> wrote:

Have you had a chance to try the branch?

— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_commaai_openpilot_issues_25270-23issuecomment-2D1213667888&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=UWAKJr_E1xW4VtuLRI3MIcnZ762mLGGqCYtgAcj1fhQ&m=Ri1YMNgenD7rGxPovvICMcL6zRYl_tocv6LUASAGUVpYtokLKXckVXj_mPucnDXF&s=rVX6lQENbjO4UX13zrx_yJ-lyqXkYpfLovL4H6TTfmM&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKIF3LE5HSG4FWHEVDJEMMDVY4RSXANCNFSM54Q2BJ6Q&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=UWAKJr_E1xW4VtuLRI3MIcnZ762mLGGqCYtgAcj1fhQ&m=Ri1YMNgenD7rGxPovvICMcL6zRYl_tocv6LUASAGUVpYtokLKXckVXj_mPucnDXF&s=djBfyyvwK1j9dlJ4btmYsNls9ohHoWbZBQljrWPCFhE&e= . You are receiving this because you authored the thread.Message ID: @.***>

ns3284 commented 2 years ago

In process of switching now. Was away from home computer, and thought I could use the built in "Change Branch" feature. That feature did not work, so manually adding remote branch and changing now.

ns3284 commented 2 years ago

Sorry for long delay, hadn't had much opportunity to try out the branch. Been using it the last couple weeks and had a longer drive yesterday. So far it seems to address the oversteering/oscillating.

On Sat, Aug 13, 2022, 01:31 Nicholas Sparks @.***> wrote:

I'll switch branches tomorrow and use it this weekend.

On Sat, Aug 13, 2022, 00:42 Adeeb Shihadeh @.***> wrote:

Have you had a chance to try the branch?

— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_commaai_openpilot_issues_25270-23issuecomment-2D1213667888&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=UWAKJr_E1xW4VtuLRI3MIcnZ762mLGGqCYtgAcj1fhQ&m=Ri1YMNgenD7rGxPovvICMcL6zRYl_tocv6LUASAGUVpYtokLKXckVXj_mPucnDXF&s=rVX6lQENbjO4UX13zrx_yJ-lyqXkYpfLovL4H6TTfmM&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKIF3LE5HSG4FWHEVDJEMMDVY4RSXANCNFSM54Q2BJ6Q&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=UWAKJr_E1xW4VtuLRI3MIcnZ762mLGGqCYtgAcj1fhQ&m=Ri1YMNgenD7rGxPovvICMcL6zRYl_tocv6LUASAGUVpYtokLKXckVXj_mPucnDXF&s=djBfyyvwK1j9dlJ4btmYsNls9ohHoWbZBQljrWPCFhE&e= . You are receiving this because you authored the thread.Message ID: @.***>

ns3284 commented 2 years ago

One thing to note about this branch. Every so often the device shows unrecognized vehicle and I need to reboot to get it back to functioning.

On Mon, Aug 29, 2022, 12:17 Nicholas Sparks @.***> wrote:

Sorry for long delay, hadn't had much opportunity to try out the branch. Been using it the last couple weeks and had a longer drive yesterday. So far it seems to address the oversteering/oscillating.

On Sat, Aug 13, 2022, 01:31 Nicholas Sparks @.***> wrote:

I'll switch branches tomorrow and use it this weekend.

On Sat, Aug 13, 2022, 00:42 Adeeb Shihadeh @.***> wrote:

Have you had a chance to try the branch?

— Reply to this email directly, view it on GitHub https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_commaai_openpilot_issues_25270-23issuecomment-2D1213667888&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=UWAKJr_E1xW4VtuLRI3MIcnZ762mLGGqCYtgAcj1fhQ&m=Ri1YMNgenD7rGxPovvICMcL6zRYl_tocv6LUASAGUVpYtokLKXckVXj_mPucnDXF&s=rVX6lQENbjO4UX13zrx_yJ-lyqXkYpfLovL4H6TTfmM&e=, or unsubscribe https://urldefense.proofpoint.com/v2/url?u=https-3A__github.com_notifications_unsubscribe-2Dauth_AKIF3LE5HSG4FWHEVDJEMMDVY4RSXANCNFSM54Q2BJ6Q&d=DwMCaQ&c=009klHSCxuh5AI1vNQzSO0KGjl4nbi2Q0M1QLJX9BeE&r=UWAKJr_E1xW4VtuLRI3MIcnZ762mLGGqCYtgAcj1fhQ&m=Ri1YMNgenD7rGxPovvICMcL6zRYl_tocv6LUASAGUVpYtokLKXckVXj_mPucnDXF&s=djBfyyvwK1j9dlJ4btmYsNls9ohHoWbZBQljrWPCFhE&e= . You are receiving this because you authored the thread.Message ID: @.***>

ns3284 commented 1 year ago

Been using for some time now. The initial issue seems to be fixed on this branch.

sshane commented 1 year ago

Any updates on this? Can we use torqued like we wanted to wait for? @nuwandavek