search

commaai / opendbc

a Python API for your car
MIT License
1.95k stars 1.14k forks source link

Honda Odyssey 2020: longitudinal API not fully understood #1174

Open haraschax opened 3 years ago

haraschax commented 3 years ago

We use PCM_GAS value to set max acceleration for Honda NIDECs, this does not work for 2020 Odyssey. We need to understand the API for this NIDEC and cars like it.

BBBmau commented 3 years ago

Hi all, would love to work on this issue. Just needing help in locating the API that you are mentioning. Thanks in Advance!

belm0 commented 3 years ago

We use PCM_GAS value to set max acceleration for Honda NIDECs, this does not work for 2020 Odyssey.

~Do you mean PCM_ACCEL?~

(I assume that merged PR commaai/openpilot#22156 was the workaround for this issue.)

belm0 commented 3 years ago

I see, it's PCM_GAS

https://github.com/commaai/openpilot/blob/3ccf712ac99ce8ef393d87ddd7241d1d823dd5a6/selfdrive/car/honda/hondacan.py#L122

this comment threw me off, referring to it as "PCM_ACCEL":

https://github.com/commaai/openpilot/blob/3ccf712ac99ce8ef393d87ddd7241d1d823dd5a6/selfdrive/car/honda/carcontroller.py#L189-L190