Closed maxcleme closed 2 years ago
Thank you for the feedback. I'm sort of de facto maintainer of the VW DBC and port so I've filed a PR for those parts.
diff --git a/vw_mqb_2010.dbc b/vw_mqb_2010.dbc -BU_: Airbag_MQB BAP_Tester_MQB BMS_MQB Datenlogger_MQB Gateway_MQB Getriebe_DQ_Hybrid_MQB Getriebe_DQ_MQB LEH_MQB Motor_Diesel_MQB Motor_Hybrid_MQB Motor_Otto_MQB SAK_MQB Waehlhebel_MQB Vector__XXX 9 l c i XXX +BU_: Airbag_MQB BAP_Tester_MQB BMS_MQB Datenlogger_MQB Gateway_MQB Getriebe_DQ_Hybrid_MQB Getriebe_DQ_MQB LEH_MQB Motor_Diesel_MQB Motor_Hybrid_MQB Motor_Otto_MQB SAK_MQB Waehlhebel_MQB Vector__XXX l c i XXX
According to specification,
9
can't be valid network node name. It has to starts with eitheralpha_char
or_
.
Removed. That said, the network-node matrix is really not something I've maintained because openpilot doesn't use it, so I don't expect the rest of it to be all that useful.
diff --git a/vw_mqb_2010.dbc b/vw_mqb_2010.dbc -CM_ SG_ 159 EPS_HCA_Status "Status of Heading Control Assist feature" +CM_ SG_ 159 EPS_HCA_Status "Status of Heading Control Assist feature";
Misses
;
.
Fixed.
diff --git a/vw_mqb_2010.dbc b/vw_mqb_2010.dbc -CM_ SG_ 159 EPS_VZ_BLW "Raw steering angle, direction" +CM_ SG_ 159 EPS_VZ_BLW "Raw steering angle, direction";
Misses
;
.
Fixed.
diff --git a/vw_mqb_2010.dbc b/vw_mqb_2010.dbc -CM_ SG_ 294 3 "May be zero when sent by older cameras"; -CM_ SG_ 294 7 "May be zero when sent by older cameras"; -CM_ SG_ 294 254 "May be zero when sent by older cameras";
According to specification, those can't be valid signal name (
3
,7
,254
). It has to starts with eitheralpha_char
or_
.
They were also dangling references, the signal names were changed long ago. Fixed by changing the names to the ones currently used in HCA_01. As a separate matter, the whole HCA_01 message and signal structure needs to be overhauled. Doing so is on my long-term to-do list, but it requires touching a lot of things in a lot of places which won't happen today.
@jyoung8607
Glad it could help some people here, do you have any way to ping other maintainers ?
Generally, we close issues like this that should be PRs, especially when they don't affect openpilot functionality.
Closing since these don't affect openpilot functionality, but feel free to submit a PR to address these issues.
Hi,
I just wanted to report what I think are some errors/inconsistencies/invalid things on few DBC here.
While writing my own DBC parser, I end up with something working on almost everything here (I was using this repo as my testing oracle to see if everything was working fine on my end), however there is still few things I'm not able to parse, but I'm confident that my parser is correct.
I'll try to list in a diff format what I've done in order to make all files pass.