commaai / opendbc

a Python API for your car
MIT License
1.93k stars 1.12k forks source link

Fix GEARBOX signal for ILX/Ridgeline #540

Closed sshane closed 2 years ago

sshane commented 2 years ago

The ILX and Ridgeline (and Pilot, Passport) can use the same DBC for the gear shifter, however occasionally both ILX and Ruidgeline flip N and P. Either figure out which definition is correct, or find new signal, as it doesn't happen all the time, and Pilot and Passport seem to be unnafected.

Acura ILX: https://i.imgur.com/VtfExGn.jpeg Ridgeline: https://i.imgur.com/c5mkNu3.jpeg

sshane commented 2 years ago

Actually there was no N definition in the Pilot DBC, leading the default I set of P to show. When adding N for 16 to the old Pilot DBC, everything matches up now