commaai / openpilot-apks

The source code for the APK that runs inside openpilot.
MIT License
48 stars 67 forks source link

icons for left- and right-hand drive #50

Closed dan2468 closed 4 years ago

dan2468 commented 4 years ago

Based on a Discord discussion and the RHD commit description

Allow openpilot to obey left-hand traffic conventions and perform driver monitoring on right driver seat.

it’s now clear to me that the icons I proposed in this PR are for a left-/right-hand traffic toggle setting (which aids in handling the incoming traffic lanes), and not for a left/right steering wheel position toggle setting (which aids in locating the driver’s seat); arguably, the description conflates the two independent settings.

Since apparently openpilot does not currently follow any left/right-hand specific traffic conventions, I suggest that you postpone this PR, and wait for a different proposal which depicts the driving seat position, instead.