search

commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system in 275+ supported cars.
https://comma.ai/openpilot
MIT License
49.82k stars 9.08k forks source link

[Kia] eNiro 2019 doesn't show camera fw #19887

Closed VirtuallyChris closed 2 years ago

VirtuallyChris commented 3 years ago

User's car matches all existing fw in values.py, but their logs don't display the camera fw so it won't fingerprint. Do we need to add an exception for this car? Is there some fingerprinting bug? User confirmed their car has LKAS and that their harness is hooked up to the camera properly with no dash errors.

4a498ed5529e1e04|2021-01-16--13-21-58

image

Jon8RFC commented 3 years ago

Should I create a bug report for my 2018 Hyundai Sonata as well? I've been ignored on Discord for a month asking why EPS is missing.

VirtuallyChris commented 3 years ago

feel free to add your logs to this bug report too

Jon8RFC commented 3 years ago

03690f0d837307af|2020-12-29--19-57-21 shows a best case scenario when everything else is present, minus EPS:

bug_report_eps_missing

koco113 commented 3 years ago

Good evening, Mr. Chris McCammon. What is the way to find the cameras of my Kia Cadenza k7? There will be no other camera than if the vehicle is placed in the R position. The camera will operate. I hope that if you have enough information, this topic will send me a video clip for that. Thank you.

في سبت، 23 يناير، 2021 في 4:07 ص، كتب Chris McCammon < notifications@github.com>:

User's car matches all existing fw in values.py, but their logs don't display the camera fw so it won't fingerprint. Do we need to add an exception for this car? Is there some fingerprinting bug? User confirmed their car has LKAS and that their harness is hooked up to the camera properly with no dash errors.

4a498ed5529e1e04|2021-01-16--13-21-58

[image: image] https://user-images.githubusercontent.com/37757984/105563691-ee40a180-5cd3-11eb-8c1e-3230b586bf47.png

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/commaai/openpilot/issues/19887, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ5MTYEI5CTECTCAARIPDE3S3IOONANCNFSM4WPIAXKQ .

jyoung8607 commented 3 years ago

The camera may be slow to wake up. I had that same problem on VW MQB. We initially had fwdCamera in our FPv2 set, and it would work fine with the car running, or if the C2 had gone into power save shutdown. But if the car was started with openpilot already booted and ready, we would often not get a response from the camera.

openpilot regards fwdCamera as mandatory if present in the FPv2 database for that car, so we ended up taking it out of the VW MQB implementation of FPv2 entirely. In our world, the LKAS camera isn't necessarily required for openpilot support, so we needed to deal with cases where it was legitimately absent.

adeebshihadeh commented 3 years ago

@VirtuallyChris do you know if this is still an issue?

adeebshihadeh commented 2 years ago

Closing due to inactivity. There have also been improvements to the Hyundai FW query which may have resolved this.