commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system in 275+ supported cars.
https://comma.ai/openpilot
MIT License
49.23k stars 8.98k forks source link

HKG resume logic not working on Hyundai Genesis(2015-2016) #2395

Closed xps-genesis closed 1 year ago

xps-genesis commented 3 years ago

Describe the bug

The new resume logic in Master-Ci for HKG doesn't work on the Hyundai Genesis(2015-2016), This can be an issue with other older HKG cars. The resume logic is triggered when the standstill flag from SCC is set. This often allows the SCC to accept once or twice during a stop but often misses when the lead starts to move.

How to reproduce or log data

ACC activated behind a stopped target vehicle to start the resume logic

Expected behavior

Resume and continue moving when the lead starts to move.

Device/Version information (please complete the following information):

adeebshihadeh commented 3 years ago

Is this still an issue?

xps-genesis commented 3 years ago

yup still doesn't work on older vehicles

SeanCox commented 1 year ago

I tested the PR and left some notes for this https://github.com/commaai/openpilot/pull/25579

SeanCox commented 1 year ago

@adeebshihadeh This issue has been fixed.