modeld cannot recover when bridge is terminated

commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system in 275+ supported cars.

https://comma.ai/openpilot

MIT License

49.81k stars 9.08k forks source link

modeld cannot recover when bridge is terminated #24040

Closed ebadi closed 2 years ago

ebadi commented 2 years ago

Describe the bug

When bridge.py is terminated, it seems that modeld should keep trying until a frame is received. (https://github.com/commaai/openpilot/blob/master/selfdrive/modeld/modeld.cc#L89) However modeld stucks in printing vipc_client_main no frame error messages even after bridge.py is restarted.

OS Version

Ubuntu 18.04

openpilot version or commit

No response

Additional info

No response

haraschax commented 2 years ago

I could not reproduce this. When bridge is killed, openpilot goes offroad so it kills modeld anyway? When bridge restarted modeld starts from scratch?

haraschax commented 2 years ago

Closing for now

adeebshihadeh commented 2 years ago

Probably fixed as a side effect of 302b0ea9bbac0fec939919b0d09b604569305be7