search

commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system in 275+ supported cars.
https://comma.ai/openpilot
MIT License
49.81k stars 9.08k forks source link

modeld no longer draws path and lane lines on x86 (uiview.py) #24408

Closed zorrobyte closed 2 years ago

zorrobyte commented 2 years ago

Describe the bug

After reverting the commit that caused the corrupted video feed in UI, I can't get the lane lines and path to render now: image

modeld spams selfdrive/modeld/modeld.cc: vipc_client_main no frame, but this is expected according to https://github.com/commaai/openpilot/issues/24405

OS Version

Ubuntu 20.04

openpilot version or commit

05f606c8121c89990225ff873c2779fcb3790ead

Additional info

No response

pd0wm commented 2 years ago

Modeld is expecting two camera feeds. You can try setting the EnableWideCamera param to use the wide camera for both feeds. Make sure the wide camera intrinsics match your webcam.

zorrobyte commented 2 years ago

Modeld is expecting two camera feeds. You can try setting the EnableWideCamera param to use the wide camera for both feeds. Make sure the wide camera intrinsics match your webcam.

Thanks for that!

Also note that some tools are broken, like debug/uiview (which is basically just replay) as they have not been updated with the wide camera feed. I'll go ahead and try this param for both use cases and report back. I kinda suck at C, but always a good time to learn!

zorrobyte commented 2 years ago

Figured out that the TICI check exists elsewhere in the code and re-added it, also, the use_extra_client conditional was reversed. https://github.com/commaai/openpilot/pull/24421

Still not getting the drawn path, but it's a step in the right direction

zorrobyte commented 2 years ago

Fixed in https://github.com/commaai/openpilot/pull/24422