search

commaai / openpilot

openpilot is an open source driver assistance system. openpilot performs the functions of Automated Lane Centering and Adaptive Cruise Control for 250+ supported car makes and models.
https://comma.ai/
MIT License
48.6k stars 8.8k forks source link

[$100 bounty] Enable tethering doesn't work sometimes #25141

Open adeebshihadeh opened 1 year ago

adeebshihadeh commented 1 year ago

Seems to happen around 1/10 times. It's easy to tell because the IP doesn't change, and the tethering network doesn't show in the wifi list.

adeebshihadeh commented 8 months ago

@deanlee want to look into this one?

bongbui321 commented 5 months ago

@adeebshihadeh . Hmm I have been trying to replicate the issue on my computer by running ./ui and enabling the tethering option only and didn't see the issue occur. Since this is in the No hardware required section so I was experimenting on my computer only. This is how I was looking for the issue:

  1. Change the tethering_ssid in my to my hotspot name (instead of weedle)
  2. Run ./ui and enabling the tethering option
  3. After toggling on/off about 20 times I still see the IP address consistently change to my Hotspot's IP address with no issue

does this issue only happen using the comma's data or with phone's data as well? Rn I can't recreate the issue by tethering using my phone's data

adeebshihadeh commented 5 months ago

I assumed this would be a general NetworkManager issue, but it might be a quirk of the comma three or its particular version of NetworkManager. I'll change the bounty to comma device.

BBBmau commented 1 month ago

Should this still be left open? I tried tuesday to reproduce it and just wasn't able to. I'm not even sure what the first step would be to reproduce this since repeatedly turning thethering on and off just isn't consistent.

adeebshihadeh commented 1 month ago

Yes, this is still an issue. I suspect it will only happen once per boot.