commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system in 275+ supported cars.
https://comma.ai/openpilot
MIT License
49.81k stars 9.07k forks source link

Toyota Prius Two 2017 Cruise Fault, low speed lockout with disconnected DSU #26624

Closed jieyuwuCar closed 6 months ago

jieyuwuCar commented 1 year ago

Describe the bug

When running stock 8.14 on my 2017 prius two, I did not have any issues. But when updating to 0.9 I basically can no longer run stock 0.9 at this point. Every time I start the car i get the low_speed_lockout event. I'd have to disable low_speed_lockout event by hard coding that line away in order to just run stock normally.

If I comment these lines out from /openpilot/selfdrive/car/toyota/interface.py: if self.CS.low_speed_lockout and self.CP.openpilotLongitudinalControl: events.add(EventName.lowSpeedLockout)

Then I can engage Openpilot again when driving over 30mph.

Which car does this affect?

Toyota Prius Two 2017

Provide a route where the issue occurs

Occurs on startup

openpilot version

0.9

Additional info

No response

jieyuwuCar commented 1 year ago

20221122_153059

nelsonjchen commented 1 year ago

You should include your dongle id if you haven't already so comma can look at the logs.

incognitojam commented 1 year ago

@jieyuwuCar Please share a link to a route where this happens or the route name (find in https://connect.comma.ai or https://useradmin.comma.ai)

jieyuwuCar commented 1 year ago

@nelsonjchen I had to downgrade it from 0.9 to 8.14 because I am doing a lot of trips lately. So looking at the logs won't be helpful at the moment.

@incognitojam It's not a route that it happens. This happens when Comma boots up. I can never engage open pilot due to that low_speed_lockout event.

incognitojam commented 1 year ago

A route starts when you are onroad (you can see the camera), so even though you are not engaged there are still logs created. What is your dongle ID?

sshane commented 1 year ago

Discussing with user on Discord.

sshane commented 1 year ago

This is likely causing openpilot to start up late, causing cruise faults (as the car expects the DSU messages much earlier). This has always been an issue afaik, going back to older versions. https://github.com/commaai/openpilot/pull/24964

sshane commented 1 year ago

Unfortunately KWP2000 doesn't have a service to control communication, we can only put it in programming mode to silence the output, so not shippable at the moment. @jieyuwuCar does this still happen with DSU unplugged with the recent onroad transition speed up (setting power save mode)?

jieyuwuCar commented 1 year ago

I bought a SDSU and the SDSU fixed the issue.

On Mon, Aug 7, 2023, 8:50 PM Shane Smiskol @.***> wrote:

Unfortunately KWP2000 doesn't have a service to control communication, we can only put it in programming mode to silence the output. @jieyuwuCar https://github.com/jieyuwuCar does this still happen with DSU unplugged with the recent onroad transition speed up (setting power save mode)?

— Reply to this email directly, view it on GitHub https://github.com/commaai/openpilot/issues/26624#issuecomment-1668753726, or unsubscribe https://github.com/notifications/unsubscribe-auth/ATFR6N5A6DL4BRAKADOJVHTXUGELZANCNFSM6AAAAAASOWQUVA . You are receiving this because you were mentioned.Message ID: @.***>