commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system in 275+ supported cars.
https://comma.ai/openpilot
MIT License
49.59k stars 9.01k forks source link

Cruise Fault: Restart the car to engage #2740

Closed nojvek closed 3 years ago

nojvek commented 3 years ago

Describe the bug

How to reproduce or log data

Toyota Rav4 with EON running on black panda. There's roughly 1/3 chance that EON shows a "Cruise Fault: Restart the car to engage". Restarting the car doesn't fix it, restarting EON doesn't fix it. Once message appears you play game of dice to make it go away. Really annoying.

Expected behavior CommaAIi software just works.

Don't see "Cruise fault: restart car to engage" error.

Device/Version information (please complete the following information):

Additional context

pd0wm commented 3 years ago

Do you have the DSU unplugged?

Sometimes the fingerprinting takes too long to start emulating the DSU messages in time. The solution is to turn off the car and wait till completely turns off. The next drive it will be fine since the fingerprint is cached until the next boot of the EON. Rebooting the EON doesn't work since that makes it drop the cached fingerprint.

nojvek commented 3 years ago

Yeah I had DSU removed. I mucked around for a while on the highway but wanted to reach my destination so I plugged DSU back in and proceeded my merry way.

pd0wm commented 3 years ago

Closing this issue since this is kind of expect behavior for now. Hopefully we can make the firmware query somewhat faster in the future, but there are no short term plans for that.

nojvek commented 3 years ago

I understand you're closing this because of "priorities", but could we at-least make a task for this somewhere?

comma's DSU-less feature doesn't work as expected. This was not a great user experience being stuck on a highway and not being able to use any form of cruise control.

Kerman commented 3 years ago

Deeply affected by this bug in 2017 prius prime. Also dsu disabled. It’s made worse by my unit not being able to hold a charge overnight anymore. Every morning is 3-10 reboots of my car to enable openpilot. :( thank you for the tip that re enabling dsu will get me Un stuck from the side of the road with no cruise!

davisdane2 commented 1 year ago

Same problem. 2017 Prius Prime with TSS-P. Its not a fun fix but what works for me is start the car with DSU plugged in and then I have my passenger unplug the DSU unit when im traveling around 5 mph. Then I get experimental controls. Seems like the comma 3 has an established fingerprint after 10-20 seconds and the fault will not appear. Must start the car with DSU plugged in or it will give cruise fault. Sometimes I need to reboot the comma with DSU unplugged to let the comma 3 allow experimental mode.

OpenPilot lateral controls are so much better I can't go back to DSU control so this is an unfortunate problem to deal with.

I'm on Openpilot master-ci 0.9.1 w/ comma 3

edit: seems Shane's Fork 0.8.3 has the DSU handling error corrected and works normally