commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system in 275+ supported cars.
https://comma.ai/openpilot
MIT License
49.72k stars 9.05k forks source link

Cannot read fwdRadar version(in carParams values.py) from car Kia sportage 2023 5th #28210

Closed kylesongg closed 1 year ago

kylesongg commented 1 year ago

Describe the bug

To add fingerprint fwdcamera, fwdradar, I read from carParams.

But, I can't find fwdRadar version from car. my car has SCC(Smart Cruise Control)

Anyone please helps me.

-- my carParams log

log: carParams {'carParams': {'alternativeExperience': 1, 'autoResumeSng': True, 'carFingerprint': 'mock', 'carFw': [{'address': 1988, 'brand': 'hyundai', 'bus': 1, 'ecu': 'fwdCamera', 'fwVersion': b'\xf1\x00NQ5 FR_CMR AT KOR LHD 1.00 1.00 99211-P1060 665', 'logging': False, 'obdMultiplexing': True, 'request': [b'"\xf1\x00'], 'responseAddress': 1996, 'subAddress': 0}, {'address': 2004, 'brand': 'hyundai', 'bus': 1, 'ecu': 'eps', 'fwVersion': b'\xf1\x00NQ5 MDPS C 1.00 1.03 56300-P1000 1A08', 'logging': False, 'obdMultiplexing': True, 'request': [b'"\xf1\x00'], 'responseAddress': 2012, 'subAddress': 0}, {'address': 2017, 'brand': 'hyundai', 'bus': 1, 'ecu': 'transmission', 'fwVersion': b'\xf1\x00T01G00BL T01I00A1 DNQ5T16X2XI00KS0=^\xa7\x9e', 'logging': False, 'obdMultiplexing': True, 'request': [b'"\xf1\x00'], 'responseAddress': 2025, 'subAddress': 0}, {'address': 2016, 'brand': 'hyundai', 'bus': 1, 'ecu': 'engine', 'fwVersion': b'\xf1\x87391212MBA0', 'logging': False, 'obdMultiplexing': True, 'request': [b'"\xf1\x87\xf1\x81\xf1\x00'], 'responseAddress': 2024, 'subAddress': 0}, {'address': 2017, 'brand': 'hyundai', 'bus': 1, 'ecu': 'transmission', 'fwVersion': b'\xf1\x87954A22D020\xf1\x81T01I00A1 \xf1\x00T01G00BL T01I00A1 DNQ5T16X2XI00KS0=^\xa7\x9e', 'logging': False, 'obdMultiplexing': True, 'request': [b'"\xf1\x87\xf1\x81\xf1\x00'], 'responseAddress': 2025, 'subAddress': 0}, {'address': 1975, 'brand': 'hyundai', 'bus': 4, 'ecu': 'cornerRadar', 'fwVersion': b'\xf1\x00NQ5 BCW RR 1.00 , 1.01 (uR\x89"\x028\x07%', 'logging': True, 'obdMultiplexing': True, 'request': [b'"\xf1\x00'], 'responseAddress': 1983, 'subAddress': 0}, {'address': 1988, 'brand': 'hyundai', 'bus': 4, 'ecu': 'fwdCamera', 'fwVersion': b'\xf1\x00NQ5 FR_CMR AT KOR LHD 1.00 1.00 99211-P1060 665', 'logging': False, 'obdMultiplexing': True, 'request': [b'"\xf1\x00'], 'responseAddress': 1996, 'subAddress': 0}, {'address': 1971, 'brand': 'hyundai', 'bus': 4, 'ecu': 'hvac', 'fwVersion': b'\xf1\x00NQ5 97255-P1010UNIT-HEATER CONTROL 1.01 NQ5 DATC 1.3 1.00 ', 'logging': True, 'obdMultiplexing': True, 'request': [b'"\xf1\x00'], 'responseAddress': 1979, 'subAddress': 0}, {'address': 2017, 'brand': 'mazda', 'bus': 1, 'ecu': 'transmission', 'fwVersion': b'\x11"', 'logging': False, 'obdMultiplexing': True, 'request': [b'"\xf1\x88'], 'responseAddress': 2025, 'subAddress': 0}, {'address': 2017, 'brand': 'subaru', 'bus': 1, 'ecu': 'transmission', 'fwVersion': b'DNQ5T16X2XI00KS0', 'logging': False, 'obdMultiplexing': True, 'request': [b'>\x00', b'"\xf1\x82'], 'responseAddress': 2025, 'subAddress': 0}, {'address': 2016, 'brand': 'volkswagen', 'bus': 1, 'ecu': 'engine', 'fwVersion': b'\xf1\x87391212MBA0', 'logging': False, 'obdMultiplexing': True, 'request': [b'"\xf1\x87\xf1\x89\xf1\x82'], 'responseAddress': 2024, 'subAddress': 0}, {'address': 2017, 'brand': 'volkswagen', 'bus': 1, 'ecu': 'transmission', 'fwVersion': b'\xf1\x87954A22D020\xf1\x89T01I00A1 \xf1\x82DNQ5T16X2XI00KS0', 'logging': False, 'obdMultiplexing': True, 'request': [b'"\xf1\x87\xf1\x89\xf1\x82'], 'responseAddress': 2025, 'subAddress': 0}],

Which car does this affect?

Kia sportage 2023 5th

Provide a route where the issue occurs

53a213581f29dfe0|2023-05-16--21-34-01

openpilot version

0.9.2

Additional info

0.9.2 version is only added fwdCamera fingerprint

sshane commented 1 year ago

Please put your device on WiFi, I requested upload of some logs.

kylesongg commented 1 year ago

Please put your device on WiFi, I requested upload of some logs.

@sshane Hello I connected my comma3 with mobile hotspot.

Could you see some logs?

sshane commented 1 year ago

You hit a timeout on the radar ECU and nothing was logged, so I made a PR to surface these errors easier in the future here: https://github.com/commaai/openpilot/pull/28325.

As for your issue, I'm not exactly sure what's going on with your car or the comma three. On occasion nothing responds from the radar despite our request getting on the bus properly.

Sent on bus 132 (bus 4), no response:

image

However the logs point to the panda losing a message around this time exactly with several other errors, so there could be a hardware issue:

image

cc @adeebshihadeh

sshane commented 1 year ago

@kylesongg can you try a different USB C cable for the connection from the harness box to the comma three for now and see if that helps?

sshane commented 1 year ago

If that doesn't help, I recommend contacting support at https://comma.ai/support

adeebshihadeh commented 1 year ago

Possibly fixed by https://github.com/commaai/panda/commit/bf2c0071036bae4e0c00c37ae43237fce6063e31. Does it still happen on master?

adeebshihadeh commented 1 year ago

Closing due to inactivity, feel free to reopen