commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system on 275+ supported cars.
https://comma.ai/openpilot
MIT License
49.83k stars 9.08k forks source link

2017 Chevy Volt ACC Cruise Fault #32023

Closed Ohiovolt closed 6 months ago

Ohiovolt commented 7 months ago

Describe the bug

I'm using C3x with L&P harness and latest release of OP. L&P harness is functioning properly. C3x device states Cruise Fault: restart car to engage. Turning off car does not resolve issue. I have tried rotating the USB-C cable and it did not fix the issue. I have not been able to get this to work since installing the first time. IMG_3880 IMG_3882

Which car does this affect?

2017 Chevy volt with ACC

Provide a route where the issue occurs

8c4958bc2fe68698/2024-03-26--22-57-18/0

openpilot version

0.9.6

Additional info

No response

sshane commented 7 months ago

Does your car have Adaptive Cruise Control? Can you try to set SKIP_FW_QUERY=1 before launching openpilot and try again?

Such as: Kill openpilot and run SKIP_FW_QUERY=1 /data/continue.sh

Ohiovolt commented 7 months ago

Yes. It has acc. I'm not sure how to do that. Would it be in settings?

sshane commented 7 months ago

You will want to ssh into the device: https://github.com/commaai/openpilot/wiki/SSH

Ohiovolt commented 7 months ago

I am able to ssh in. Can you please share the command prompts I should type in to achieve that result

sshane commented 7 months ago

You can place this line at the top of /data/continue.sh

export SKIP_FW_QUERY=1

Ohiovolt commented 7 months ago

I really do apologize and I don't mean to sound rude but I'm not a developer and will need a little more guidance. I don't even know how to get to /data/continue.sh to include that line of code

Ohiovolt commented 7 months ago

I ran the following command prompts:

echo -en "1" > /data/params/d/DisableUpdates Then echo "export SKIP_FW_QUERY=1" >> /data/openpilot/launch_env.sh

I then rebooted the device and went for a drive. It did not resolve the issue.

Route: 8c4958bc2fe68698/2024-03-27--11-56-59/5

sshane commented 7 months ago

That did not seem to take. Try this command once, then reboot the device and start the car once the device is back up:

sed -i '1 aexport SKIP_FW_QUERY=1' launch_openpilot.sh
Ohiovolt commented 7 months ago

I followed your instructions but not sure this one took either as I'm still experiencing the same issue.

Route: 8c4958bc2fe68698/2024-03-28--09-19-10/0

Ohiovolt commented 7 months ago

Do you have any other suggestions? Do you think it's a hardware or software issue? Should I try installing a previous version of OP or just return the c3x for a new one?

sshane commented 7 months ago

After 10 seconds or so, boardd thinks that sendcan is more than a second off and it stops sending the CAN messages, but in the logs the timing looks all correct for sendcan and can. @adeebshihadeh do you have any ideas?

image

The first time is nanos_since_boot() in boardd and the rate they both increase don't match.

[24.099975] selfdrive/boardd/boardd.cc:232 - can_send_thread: sendcan too old to send: 251973676638, 250688230649
[24.100018] selfdrive/boardd/boardd.cc:232 - can_send_thread: sendcan too old to send: 251973676638, 250688230649
[24.100253] selfdrive/boardd/boardd.cc:232 - can_send_thread: sendcan too old to send: 251973707003, 250699614972
[24.100209] selfdrive/boardd/boardd.cc:232 - can_send_thread: sendcan too old to send: 251973707003, 250699614972
[24.100467] selfdrive/boardd/boardd.cc:232 - can_send_thread: sendcan too old to send: 251973762419, 250709298513
[24.100425] selfdrive/boardd/boardd.cc:232 - can_send_thread: sendcan too old to send: 251973762419, 250709298513
[24.100677] selfdrive/boardd/boardd.cc:232 - can_send_thread: sendcan too old to send: 251973793096, 250721121013
[24.100635] selfdrive/boardd/boardd.cc:232 - can_send_thread: sendcan too old to send: 251973793096, 250721121013
[24.100882] selfdrive/boardd/boardd.cc:232 - can_send_thread: sendcan too old to send: 251973839659, 250728695545
clementcho commented 7 months ago

Okay, so I ran a Fingerprinting 2.0 procedure from here: https://github.com/commaai/openpilot/wiki/Fingerprinting I got carFw = [ ]. That would definitely cause a problem. My route is 9dad298fbcfbca02%7C00000004--1a720dd784 I also attached the segment 0 txt in this.

2024-03-30 Route_9dad298fbcfbca0200000004_1a720dd784.txt

sshane commented 7 months ago

Can you try the master branch? I can give you a branch to debug this after

Ohiovolt commented 7 months ago

How would I do this? I'll need very specific step by step instructions. I'm not tech savvy when it comes to this.

sshane commented 7 months ago

Use this installer URL: https://installer.comma.ai/commaai/master-ci

Ohiovolt commented 7 months ago

Ok it is installed but it is giving me the same cruise fault.

sshane commented 7 months ago

Okay, now try this one: https://installer.comma.ai/commaai/volt-no-fault

Ohiovolt commented 7 months ago

Still getting cruise fault. My drive isn't syncing with comma connect to share my route.

Was that supposed to be the fix or is there another step?

Ohiovolt commented 7 months ago

I need to know if this is a software or hardware problem and if this is compatible with my vehicle or if I need to return this.

adeebshihadeh commented 7 months ago

I strongly suspect this is a software issue. Feel free to return it now, but we'll extend your return window up to 60 extra days if you're willing to wait a bit for a software fix.

@sshane let's get this resolved ASAP.

Ohiovolt commented 7 months ago

Yes absolutely. Thank you. I'm willing to work with your team to get this resolved. I literally just purchased this car 3 weeks ago for the sole purpose of being able to use OP.

sshane commented 6 months ago

@Ohiovolt can you pull the branch I gave you and retry? I added extra logging.

Ohiovolt commented 6 months ago

Sorry just to confirm, By pull do you mean uninstall and reinstall?

sshane commented 6 months ago

You can check for updates in the UI if you're still on the same branch.

Ohiovolt commented 6 months ago

@sshane it seems to be stuck on finalizing update. It's been on this for over 20 min. image

Ohiovolt commented 6 months ago

This is the error I'm getting now. image

sshane commented 6 months ago

Can you uninstall and re-install? We're currently re-working the updater

Ohiovolt commented 6 months ago

@sshane latest route using updated branch

https://connect.comma.ai/8c4958bc2fe68698/1712616517731/1712616795935

sshane commented 6 months ago

It didn't upload the first rlog, potentially because the log file was too big. Can you start the car for a max of 15 seconds or until it faults and then turn it off?

Ohiovolt commented 6 months ago

Try this:

https://connect.comma.ai/8c4958bc2fe68698/1712616828393/1712616847031

sshane commented 6 months ago

I pushed an update to the branch, does fetch updates work? If not, you can ssh in and git pull and reboot (fastest), or re-install (slowest). This time wait for 10+ seconds after it faults.

sshane commented 6 months ago

I think this may be a potential hardware failure with your harness or the panda, unsure yet. We are not seeing any CAN traffic on bus 2/chassis bus and that CAN core is returning many stuff errors. Since we send a friction brake command on that bus, the tx buffer is likely filling up and causing the panda to return NACK as it's not ready for more messages yet.

@Ohiovolt Can you describe your hardware set up and how you hooked everything up? Which harness did you get for the ASCM? Lee & Paulding? There's a few options you could have done here: https://github.com/commaai/openpilot/wiki/GM#hardware

Ohiovolt commented 6 months ago

https://connect.comma.ai/8c4958bc2fe68698/1712623924067/1712623945684

Ohiovolt commented 6 months ago

I am using the L&P harness with c3x and followed the instructions as detailed. ACC works when c3x is not plugged in.

Ohiovolt commented 6 months ago

I did receive a canbus error before I reboot after the pull and tried flipping the usb-c around. This is the most recent route.

https://connect.comma.ai/8c4958bc2fe68698/1712624150640/1712624165661

sshane commented 6 months ago

Have you tried a new USB C cable yet? The errors switch sides when you flipped the cable. You can use a third party USB C 3.1 gen 2 cable if you have one.

Ohiovolt commented 6 months ago

I can try using the other shorter usb-c cable that came with the hardware.

Ohiovolt commented 6 months ago

Using the shorter cord that came with the hardware with the 90 degree seemed to have given the car more problems: https://connect.comma.ai/8c4958bc2fe68698/1712626264948/1712626283746

USB Flipped: https://connect.comma.ai/8c4958bc2fe68698/1712626356892/1712626391018

sshane commented 6 months ago

It looks like the culprit is either the comma OBD connector or the third party L&P harness. Because it is difficult to diagnose here and the high likelihood of third party hardware being the problem, I suggest you consider making a return request at https://shop.comma.ai/a/returns.

Ohiovolt commented 6 months ago

Why did you close this issue? Are you able to send me a replacement device in the meantime?

On Apr 9, 2024, at 4:28 PM, Shane Smiskol @.***> wrote:

Closed #32023 https://github.com/commaai/openpilot/issues/32023 as not planned.

— Reply to this email directly, view it on GitHub https://github.com/commaai/openpilot/issues/32023#event-12412551799, or unsubscribe https://github.com/notifications/unsubscribe-auth/BHLWTDUEIVVIVSOZMUAEKHLY4RFPRAVCNFSM6AAAAABFKDCQN2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGQYTENJVGE3TSOI. You are receiving this because you were mentioned.

clementcho commented 6 months ago

Sshane, may I ask what's is the new comma power need to read from CANS that is not getting on Gray Panda or the old Comma Power on Comma 3? Or if the Comma 3 and 3X are using the same Comma Power, then the culprit would fall into the Red Panda (I assume the built-in panda in comma 3x is red). Given I can see Comma 3 was able to be successfully installed on Volt 2017 as the YouTube demo shows here https://youtu.be/QeMCN_4TFfQ I got this link from the openpilot code.

Ted2645 commented 6 months ago

Hi, im having this exact same issue. I just got.my l and p harness and have been going through everything on the install triple checking my cabling thinking I screwed something up. Is there a fix? I litterally bought this specific volt to use with comma ai. I am willing to work with anyone to figure this out! I hope ohiovolt didn't give up.

https://github.com/commaai/openpilot/assets/145208556/7b74e499-0b74-4a40-a34c-9a26b63fa88a

https://github.com/commaai/openpilot/assets/145208556/10e2d7e8-77e4-4480-981e-694ba03043bf

Ted2645 commented 6 months ago

Hey! Hopefully Ohiovolt didn't take the comma back I fixed mine.... it was the switch at the back near the ascm I'll attach a picture! Make sure it's switched to "op"

https://github.com/commaai/openpilot/assets/145208556/64ad2e5f-ff7e-4798-8a11-40cdd0b8ecd6

20240410_175506

Ted2645 commented 6 months ago

Mine seemed like it was set to op, but I redid it and bam calibrating! Great success. Can't wait to try out experimental

Ohiovolt commented 6 months ago

Unfortunately I believe the issue is with my comma obd adapter. I am hoping they send me hardware. Still waiting on their response from Sam. Sent from my iPhoneOn Apr 10, 2024, at 6:30 PM, Ted2645 @.***> wrote: Hey! Hopefully Ohiovolt didn't take the comma back I fixed mine.... it was the switch at the back near the ascm I'll attach a picture! Make sure it's switched to "op" https://github.com/commaai/openpilot/assets/145208556/64ad2e5f-ff7e-4798-8a11-40cdd0b8ecd6 20240410_175506.jpg (view on web)

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>

Ted2645 commented 6 months ago

They told me I would need to buy another obd2 usbc sensor from them, they wouldn't send me one for the trouble. Said I would have 30 days from purchase to refund..... hope you get it worked out

clementcho commented 6 months ago

They told me I would need to buy another obd2 usbc sensor from them, they wouldn't send me one for the trouble. Said I would have 30 days from purchase to refund..... hope you get it worked out

Did you say you are actually able to drive your Volt with Comma 3X after you switch from OP to Dealer mode? Have you done the road test yet?

Ted2645 commented 6 months ago

Yes, I got it working

Get Outlook for Androidhttps://aka.ms/AAb9ysg


From: clementcho @.> Sent: Thursday, April 11, 2024 1:03:42 AM To: commaai/openpilot @.> Cc: Ted2645 @.>; Comment @.> Subject: Re: [commaai/openpilot] 2017 Chevy Volt ACC Cruise Fault (Issue #32023)

They told me I would need to buy another obd2 usbc sensor from them, they wouldn't send me one for the trouble. Said I would have 30 days from purchase to refund..... hope you get it worked out

Did you say you are actually able to drive your Volt with Comma 3X after you switch from OP to Dealer mode? Have you done the road test yet?

— Reply to this email directly, view it on GitHubhttps://github.com/commaai/openpilot/issues/32023#issuecomment-2048931118, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCT3J3DXB5LJ7FROI7PWU2LY4YKS5AVCNFSM6AAAAABFKDCQN2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBYHEZTCMJRHA. You are receiving this because you commented.Message ID: @.***>

Ted2645 commented 6 months ago

Funnily enough I installed sunnypilot and messed around with cabling a bit more (mainly that switch in the back) and it started working after 4 hours of troubleshooting. I would run through all tour cabling again. I took this car apart 4 times :(

Ted2645 commented 6 months ago

Also check this fuse, I had mine pointed up and if was causing issues,

![Uploading 20240411_143842.jpg…]()