search

commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system in 275+ supported cars.
https://comma.ai/openpilot
MIT License
49.22k stars 8.97k forks source link

C3 Screen Too Bright @ Night #33041

Open jsegill opened 1 month ago

jsegill commented 1 month ago

Describe the bug

Since installing 0.9.7 screen brightness at night on the C3 has been way too bright. Usually the night compensation for brightness works well, seems to have changed w/ 0.9.7.

Route below is an example of a bad screen brightness at night.

Whole route has the issue happening.

Provide a route where the issue occurs

4ecfcac756318cbf/00000035--99d3637ece

openpilot version

0.9.7, release3

Additional info

Fixing the brightness compensation is good but I would suggest adding an alternative brightness toggle. The user would be able to easily override screen brightness settings if they do not like stock brightness settings.

CruiseBrantley commented 1 month ago

It's not an intermittent issue at all, for me at least. Pick any route at night with this dongle 149d6f706527cfe1 Here's 1 example 149d6f706527cfe1/00000115--907e342143 Essentially just stuck at 100% brightness it seems, I only notice it at night (every time) but possibly any route just not being noticeable during the day.

jkbkster commented 1 month ago

Night driving only possible with manual brightness setting currently

wired4sound commented 1 month ago

Commenting to say I am having this issue as well recently.

Blinding at night at like 100%. Manually turn down. Then during day, can't see screen unless I shade it from the sun to turn it back up again because I cranked it down the night before.

adeebshihadeh commented 3 weeks ago

Can you guys test installer.comma.ai/commaai/fix-too-bright?

MarcoTheDingo commented 3 weeks ago

@adeebshihadeh looks like that helped! Not as dim as I personally keep my infotainment, but it was enough that it wasn't blinding. Route: 5130484aa8069bad/000000c9--4b7e4e53c6

MarcoTheDingo commented 2 weeks ago

@adeebshihadeh are you looking for any other users to test, or any other routes to merge this?

adeebshihadeh commented 2 weeks ago

So that isn't a mergable branch, it's just a test. Now that it's been tested, I'll come up with a mergable branch for you guys to test soon.

jsegill commented 2 weeks ago

I can also test in a couple of days. Just really busy the last week...

jsegill commented 20 hours ago

Worked well on this route today 4ecfcac756318cbf/00000000--abb1191d75/0

MarcoTheDingo commented 5 hours ago

The more I use this branch the more it seems like it's just darkening the input from the cameras and not the actual screen. If I open the sidebar or go into settings it's just as bright as not being on this branch.

Looking back at old footage from previous releases, the screen was a lot darker. Is there a way to reinvestigate this as an auto brightness issue instead of the gamma input on the cameras?

adeebshihadeh commented 4 hours ago

Looking back at old footage from previous releases

What footage? You can't tell this from the device's logs, unless you mean recording a video of the device with your phone?

MarcoTheDingo commented 4 hours ago

Yes looking at old footage I recorded of the comma 3 and from my own memory, it was a lot dimmer.