search

commaai / openpilot

openpilot is an operating system for robotics. Currently, it upgrades the driver assistance system on 275+ supported cars.
https://comma.ai/openpilot
MIT License
49.94k stars 9.11k forks source link

controlsd: resume from stop doesn't work with stock long #33850

Open sshane opened 3 weeks ago

adeebshihadeh commented 3 weeks ago

Doesn't matter since we're going to use openpilot long

sshane commented 3 weeks ago

Right, but this looks like a regression for all the stock long cars (cruiseControl.resume never activates). Will re-visit after Ford.

BBBmau commented 3 weeks ago

I'm experiencing this also except it's on experimental. I have a '23 Sonata with device on master with commit af73d6084d5ac77935282442c909432eebd676d1 i believe.

Edit: The actual commit on the device is 6175106b197f811a0da2dc1856a31abf9f0a9a82

sshane commented 3 weeks ago

Can you post a route where this happens?

BBBmau commented 3 weeks ago

@sshane Edit: correct route is

https://connect.comma.ai/9a31d18cd1a79c69/00000177--035b67fbc9/160/164

9a31d18cd1a79c69/00000177--035b67fbc9/2

sshane commented 3 weeks ago

The model in experimental mode failing to resume at traffic lights is different than controlsd setting the carControl.cruiseControl.resume signal based on the planner/lead BTW, that's what this issue is for

BBBmau commented 3 weeks ago

The model in experimental mode failing to resume at traffic lights is different than controlsd setting the carControl.cruiseControl.resume signal based on the planner/lead BTW, that's what this issue is for

yeah the route is wrong, I'll be providing the route with the actual issue later today. Sorry for the confusion.

BBBmau commented 3 weeks ago

@sshane looking to see what needs to be changed. A bit interesting how on resume it goes to the saved speed but is quickly reverted to be 65

image