search

commaai / panda

code powering the comma.ai panda
MIT License
1.52k stars 766 forks source link

Add 10 mutation tests #1797

Closed bongbui321 closed 8 months ago

bongbui321 commented 8 months ago

For #1770. I removed the (None, None, False) case since it was checked in the step before misrac check already, and it slows down CI time

Just to make sure I understand the bounty, the added patterns have to replace the part of the code while maintaining the same functionality?

adeebshihadeh commented 8 months ago

For #1770. I removed the (None, None, False) case since it was checked in the step before misrac check already, and it slows down CI time

We want to keep this. It's a better test this way, otherwise we can easily write a bug where the test always fails but for reasons other than the violations we setup. Checking that it still passes with no patches catches that bug.

Just to make sure I understand the bounty, the added patterns have to replace the part of the code while maintaining the same functionality?

Not necessarily. Ideally what we want here are generic patterns (not specific to any file) that we can then mix and match with files.