search

commaai / panda

code powering the comma.ai panda
MIT License
1.52k stars 763 forks source link

Hardware pin names refactor #1856

Closed dzid26 closed 7 months ago

dzid26 commented 7 months ago

  1. Why I changed "sbu relay" to "switch"? SBUs lines are driving the relay, yes, but it is more logical to use "switch" since each SBU has its own transistor activated depending on cable rotation. Yes, transistor can be called relay, but it's better to say "switch" which separates it from the mechanical relay in the harness.

  2. Why I changed "Ignition relay" to "Ignition test probe"? Because by the same logic as with "harness relay", this implied there was a second relay (or a transistor) that can be driven. But there isn't anything that can be switched. All this does, is pulls harness sbu2 line voltage higher.

adeebshihadeh commented 7 months ago

Closing since this name is also on a bunch of schematics. It'll be more confusing (at least to us) to have a different name here.