search

commaai / panda

code powering the comma.ai panda
MIT License
1.52k stars 757 forks source link

Defining types in return dictionaries #1923

Open MarinkoMagla opened 4 months ago

MarinkoMagla commented 4 months ago

It was under "TODO" in python/ccp.py to define types for couple of function returns.

MarinkoMagla commented 3 months ago

Hi @adeebshihadeh, can you take another look on this?

adeebshihadeh commented 3 months ago

This comment still applies https://github.com/commaai/panda/pull/1923#discussion_r1552267692

adeebshihadeh commented 3 months ago

Linter is still failing

MarinkoMagla commented 2 months ago

Hi @adeebshihadeh, linter is ok now, can you take another look?