commaai / panda

code powering the comma.ai panda
MIT License
1.5k stars 744 forks source link

Cppcheck 2.14 #1951

Closed dzid26 closed 1 month ago

dzid26 commented 1 month ago

This upgrades to Cppcheck 2.14 and fixes new violations that showed up after the upgrade.

Related https://github.com/commaai/panda/issues/1794, https://github.com/commaai/panda/issues/1954

dzid26 commented 1 month ago

https://github.com/commaai/panda/pull/1951/commits/97b2ca8864279ebdb108cc5475e2517c3cd680b5 was tested with panda by running recover.py twice (first time to flash bootstub, second time to see if it still jumps to dfu bootloader correctly)

dzid26 commented 1 month ago

To be sure I tested the bootloader function again by running recover.py twice.

The new minor version of cppcheck just came out and caused fetching error when running test_misra.py. - I bumped the version and also added --force for the future.