search

commaai / panda

code powering the comma.ai panda
MIT License
1.54k stars 788 forks source link

remove void return #1963

Closed dzid26 closed 6 months ago

dzid26 commented 6 months ago

It looks that's the only one

adeebshihadeh commented 6 months ago

Is there a cppcheck or compiler flag we can enable to catch this?

dzid26 commented 6 months ago

It would be -Wpedantic or some other ISO-C option which in turn ignores -std=gnu11 and throws bunch of other errors. I tried selectively suppressing them with #pragmas, but that didn't want to work. It would need to be investigated more, but so far I am pessimistic.

I haven't seen this check in cppcheck.