search

commaai / panda

code powering the comma.ai panda
MIT License
1.52k stars 763 forks source link

Convert to pytest #1982

Closed UkuLoskit closed 2 weeks ago

UkuLoskit commented 2 months ago

There is an issue with the usbprotocol tests, they depend on a particular ordering of the tests. I used pytest-order to preserve the default ordering of unittest. Additionally, these tests cannot be run in parallel. Used this ordering as a crutch to work around this.

maxime-desroches commented 1 month ago

@UkuLoskit Do you plan on finishing this up soon?

UkuLoskit commented 1 month ago

@maxime-desroches hey, ready for review now with some caveats described in the PR description.

UkuLoskit commented 1 month ago

There are actually more tests ... fixing these

adeebshihadeh commented 1 month ago

trigger-jenkins

adeebshihadeh commented 2 weeks ago

Closing, I left feedback and it wasn't addressed. Feel free to open a new one without any "crutches". More background here.