search

commanded / commanded-extreme-adapter

Extreme event store adapter for Commanded
MIT License
12 stars 18 forks source link

Supervisor for Subscription processes #8

Closed jfornoff closed 6 years ago

jfornoff commented 6 years ago

This PR adds a SubscriptionsSupervisor, which is responsible for keeping track of the currently started Subscriptions.

This removes the need for manual bookkeeping in Commanded.EventStore.Adapters.Extreme and we can port it from a GenServer to a plain module.

This fixes an issue where Commanded.EventStore.Adapters.Extreme could crash and forget about the subscriptions that were already started, which could cause duplicate Subscription-processes to be started, until the maximum subscriber count of EventStore is reached.

Please feel free to make any adjustments :-)

jfornoff commented 6 years ago

Not sure what it's about the CI that is causing issues over there, the tests are all green on my machine now