commanded / eventstore

Event store using PostgreSQL for persistence
MIT License
1.06k stars 146 forks source link

CI skips slow tests even though they are expected to run. #284

Closed thomasdziedzic closed 3 hours ago

thomasdziedzic commented 8 months ago

From https://github.com/commanded/eventstore/issues/283#issuecomment-2016570951

I think I found out why this regression was introduced. CI runs mix test.all but I didn't see any logs of the slow tests being run in CI. I tried running mix test.all locally and indeed they all pass because the slow tests don't run. I tried to narrow the problem down and found that if I have test.all defined as "test.all": ["test", "test --only slow"], then the slow tests don't run. But if I have "test.all": ["test --only slow"], then the slow tests do run and the expected failure shows up. I'm not exactly sure why the slow tests get skipped when there's a previous test that gets run.

drteeth commented 3 hours ago

https://github.com/commanded/eventstore/pull/289 now includes "slow" tests in all cases.