search

commander-rb / commander

The complete solution for Ruby command-line executables
MIT License
822 stars 74 forks source link

Update highline #102

Closed belousovAV closed 7 months ago

belousovAV commented 7 months ago

Update highline gem to fix ruby 3.3 warning

Increase ruby version to match highline gem requirements

lacostej commented 7 months ago

I would love commander to relax its dependency on highline, so that we could use version 3.0.0 or later in fastlane, but we wouldn't be able to upgrade to a version that forces ruby 3.0 yet.

Update: Well I didn't realize highline 3 requires ruby 3.0, so not much arguing...

ggilder commented 7 months ago

Thanks for doing this. Since the version requirement is a breaking change for older versions of Ruby, I'm going to bump commander up a major version as well to 5.0.0. I'll push that later today.

ggilder commented 7 months ago

Published! https://rubygems.org/gems/commander

ggilder commented 7 months ago

@lacostej let me know if this works for fastlane; don't know if you're planning to keep supporting ruby < 3.0 since those are EOL... I think you could change fastlane's dependency on commander to >= 4.6.0 to allow either the previous version, or the new version when running ruby 3.