Fix Ruby 2.5.0 warning; add latest Rubies to Travis

commander-rb / commander

The complete solution for Ruby command-line executables

MIT License

822 stars 74 forks source link

Fix Ruby 2.5.0 warning; add latest Rubies to Travis #62

Closed mattbrictson closed 6 years ago

mattbrictson commented 6 years ago

This PR fixes the following warning on Ruby 2.5.0:

commander-4.4.3/lib/commander/user_interaction.rb:334: warning: constant ::Data is deprecated

Also:

Add Ruby 2.5.0 to Travis
Change other Travis Rubies to their latest patch versions
Enable Bundler cache on Travis
Pin RuboCop at 0.49 (0.50 and above don't support Ruby 1.9 syntax)

Fixes #61

rous-gg commented 6 years ago

+1 for this one

ggilder commented 6 years ago

Thanks for fixing the warning, and taking time to update Travis/Rubocop!

The more I think about the ask_for_* feature, the more I wonder if anyone actually uses it or if it should be reimplemented in a less annoying way... 😉

ggilder commented 6 years ago

Released in version 4.4.4.