Correctly handle global options provided in the option=value form

commander-rb / commander

The complete solution for Ruby command-line executables

MIT License

822 stars 74 forks source link

Correctly handle global options provided in the option=value form #90

Closed orien closed 4 years ago

orien commented 4 years ago

As identified in #47, global options are not removed from the command options when provided in the form option=value. This results in an invalid option error when parsing the command specific options.

Proposed in this PR is an implementation to fix this.

Fixes #47.

ggilder commented 4 years ago

Looks great! Please rebase this branch off latest master and squash the commits to clean up the history and then I think this is ready to merge.

orien commented 4 years ago

Squashed in c966a85.

orien commented 4 years ago

@ggilder I think this one is good to go 😄

ggilder commented 4 years ago

👍

ggilder commented 4 years ago

Released in v4.5.2