Closed esotericpig closed 4 years ago
Looks good, thanks! Could you rebase and squash your two commits together?
Okay, I rebased it. I had to merge in some conflicts. Hopefully it's okay. Thanks.
Hmm, that doesn't look quite right. If you run an interactive rebase, e.g. git rebase -i master
, you should be able to remove the extraneous commits and just include your squashed commit.
After I rebased, it kept having conflicts, so I reverted it back to head, which then closed this pull request.
I reopened a new one at pull/93.
In Ruby v2.7, you'll get the following warnings:
There might be more warnings for v2.7, but these are the only ones I get so far.