Resolution to issue 98 SortedSet

briancolfer-upstart commented 3 years ago

The rspec tests now pass.

ggilder commented 3 years ago

Please explain the reason for this change, thanks.

briancolfer-upstart commented 3 years ago

I wasn't clear enough with my description. The rspec tests failed because the gem SortedSet was removed from the set library:

commander git:(master) bundle exec rspec
......................................................F..................................................................................

Failures:

  1) Commander::Methods AskForClass defining methods implements "ask_for_*"
     Failure/Error: Object.const_get(const)

     RuntimeError:
       The `SortedSet` class has been extracted from the `set` library.You must use the `sorted_set` gem or other alternatives.
     # ./lib/commander/user_interaction.rb:347:in `require'
     # ./lib/commander/user_interaction.rb:347:in `const_get'
     # ./lib/commander/user_interaction.rb:347:in `block in method_missing'
     # ./lib/commander/user_interaction.rb:346:in `map'
     # ./lib/commander/user_interaction.rb:346:in `method_missing'
     # ./spec/methods_spec.rb:49:in `block (4 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # LoadError:
     #   cannot load such file -- sorted_set
     #   ./lib/commander/user_interaction.rb:347:in `require'

Finished in 0.1853 seconds (files took 0.2501 seconds to load)
137 examples, 1 failure

Failed examples:

rspec ./spec/methods_spec.rb:47 # Commander::Methods AskForClass defining methods implements "ask_for_*"

Coverage report generated for RSpec to /Users/brian.colfer/packages/commander/coverage. 399 / 473 LOC (84.36%) covered.

commander-rb / commander

Resolution to issue 98 SortedSet #99