search

commanderx16 / x16-emulator

Emulator for the Commander X16 8-bit computer
384 stars 61 forks source link

add descriptive reason message when dumping system memory file #460

Closed irmen closed 1 year ago

irmen commented 1 year ago

The emulator writes a memory dump file when pressing CTRL/Command + S, and when the program counter reaches $ffff

This PR adds a descriptive message to the console as well so you can tell why exactly it is writing the dump file. This helps diagnosing what's happening, and for me at least, to tell it apart from an unexpected segfault crash/coredump

Dumping system memory. Reason: user keyboard request
Dumped system to dump-7.bin.
Dumping system memory. Reason: CPU program counter reached $ffff
Dumped system to dump-8.bin.
indigodarkwolf commented 1 year ago

Looks good to me, and seems like a very reasonable inclusion since folks have gotten confused over this detail multiple times.