commanderx16 / x16-rom

Other
153 stars 43 forks source link

Basic bank statement #340

Closed stefan-b-jakobsson closed 1 year ago

stefan-b-jakobsson commented 1 year ago

Implementation of a new BANK statement in BASIC.

The bank set by BANK is used by SYS, POKE and PEEK if the target address is >= $a000

Example (starts GEOS by calling $C000 in ROM bank 3):

BANK 3
SYS $C000
stefan-b-jakobsson commented 1 year ago

I think I fixed all comments from @mist64

stefan-b-jakobsson commented 1 year ago

By mistake a change in the GEOS launch code intended for my other PR (fix-geos) had sneaked in here. It was removed with git revert (commit 780b786) above.

irmen commented 1 year ago

Should the LOAD commands also consider the BANK ?

mist64 commented 1 year ago

Should the LOAD commands also consider the BANK ?

LOAD and SAVE could benefit from this, yes!

https://github.com/commanderx16/x16-rom/issues/345