commandgeek / GeekSMP

GeekSMP Plugin
Other
13 stars 4 forks source link

Skeleton arrow pickup and username formatting fix #42

Closed Lianecx closed 2 years ago

Lianecx commented 2 years ago

Arrows can still be picked up by peole in creative. fixed #37 fixed #41

Lianecx commented 2 years ago

Oh sorry i pushed the username fix here as well

srnyx commented 2 years ago

Oh sorry i pushed the username fix here as well

If you wanna separate it next time you have to make a separate branch on your fork and then select that branch when making a new pull request.

Lianecx commented 2 years ago

Ye ik i forgot to do that

Lianecx commented 2 years ago

i did it again -_- Sorry ill create a new branch

Lianecx commented 2 years ago

Dont merge it yet, i think it escapes the emojis

Lianecx commented 2 years ago

Should chat messages also be escaped or should people be allowed to send stuff like bold to discord?

srnyx commented 2 years ago

Should chat messages also be escaped or should people be allowed to send stuff like bold to discord?

They should be allowed in chat messages, only the name should be escaped. Also, make sure that it doesn't escape the ** around the name when a user joins/leaves the game.

Lianecx commented 2 years ago

Okay great, @commandgeek you can approve this now

srnyx commented 2 years ago

Checks passed, it also didnt throw any errors for me... I overloaded the replace method to have a third argument which escapes the markdown of the replacment text and then replaces it

Reply inside the conversation please image