commandgeek / GeekSMP

GeekSMP Plugin
Other
13 stars 4 forks source link

Undead adventure mode, iron golems fix, remove pets #50

Closed Lianecx closed 2 years ago

Lianecx commented 2 years ago
DWAA1660 commented 2 years ago

did you just completely remove pets :/

Lianecx commented 2 years ago

I think so lol, gonna fix that tmr

Lianecx commented 2 years ago

Commits are a little confusing, sry about that

srnyx commented 2 years ago

did you just completely remove pets :/

Oh yeah, that seems to be an issue then. But we are considering removing pets anyway. So @Lianecx since it's not possible to implement pets with adventure mode just remove pets entirely. If we decide we don't want pets, we'll merge. If we want to keep pets we'll close.


Or, if we really wanna keep pets but still make use of adventure mode we could have it so: Pets: survival mode (still with all the block place/break event stuff) Not a pet: adventure mode or Base it off proximity: Pet near owner: survival mode Pet not near owner / not a pet: adventure But either of these methods may be a bit more complicated and unnecessary if pets aren't really used and/or are abused.

Lianecx commented 2 years ago

Exactly, thats what i was going to do. Set them to survuival mode as soon as they get in range

Lianecx commented 2 years ago

So tell me if i should implement that or just remove then

Lianecx commented 2 years ago

So what about the pets?

srnyx commented 2 years ago

So what about the pets?

We've decided to remove entirely. So remove any pet stuff.

Lianecx commented 2 years ago

Okay so should i remove them?

srnyx commented 2 years ago

Okay so should i remove them?

Yes...

Lianecx commented 2 years ago

I removed the pet command. I don't really want to remove any code, I leave that to commandgeek